Re: REPACK (CONCURRENTLY) can crash a logical decoding session - Mailing list pgsql-hackers

On Tue, Sep 29, 2026 at 1:00 PM Alexander Lakhin <exclusion@gmail.com> wrote:
>
> Hello Sawada-san,
>
> 11.09.2026 20:56, Masahiko Sawada wrote:
>
> No objections here -- they look good to me too.  The isolation spec
> addition is great, thanks.
>
> Thank you for looking at the patches! Pushed.
>
>
> A recent failure of repack_decode.spec emitted by skink [1]:
> # diff -U3 /home/bf/bf-build/skink-master/HEAD/pgsql/src/test/modules/injection_points/expected/repack_decode.out
/home/bf/bf-build/skink-master/HEAD/pgsql.build/testrun/injection_points/isolation/results/repack_decode.out
> # --- /home/bf/bf-build/skink-master/HEAD/pgsql/src/test/modules/injection_points/expected/repack_decode.out
2026-09-2523:32:42.088355239 +0200 
> # +++ /home/bf/bf-build/skink-master/HEAD/pgsql.build/testrun/injection_points/isolation/results/repack_decode.out
2026-09-2918:01:56.818281263 +0200 
> # @@ -26,7 +26,7 @@
> #
> #  count
> #  -----
> # -    8
> # +   12
> #  (1 row)
> #
> #  injection_points_detach
> # 1 of 16 tests failed.
>
> apparently shows that the test is not immune to autovacuum.

Thank you for the report. My bad.

I've attached the patch that should fix the issue.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com