Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p - Mailing list pgsql-committers

On Tue, Mar 11, 2025 at 7:08 PM David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Wed, 12 Mar 2025 at 05:57, Masahiko Sawada <msawada@postgresql.org> wrote:
> > contrib/pg_logicalinspect/pg_logicalinspect.c      | 55 ++++++++++++---
>
> This introduces a new compiler warning for compilers that don't know
> the ereport(ERROR) does not return.
>
> The attached is enough to fix it.

Thank you for the report. Can we generate the warning using some gcc's
warning flags? I'd like to add a check to my personal pre-commit test.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com