Postgres Pro
Downloads
Home   >   mailing lists

Re: Use the enum value CRS_EXPORT_SNAPSHOT instead of "0" - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Use the enum value CRS_EXPORT_SNAPSHOT instead of "0"
Date
Msg-id CAD21AoDM7GwJfYmhwhdMLmw1dJjAijKyO+W6S-oHi7_CzqtpVA@mail.gmail.com
Whole thread Raw
In response to Use the enum value CRS_EXPORT_SNAPSHOT instead of "0"  ("Wei Wang (Fujitsu)" <wangw.fnst@fujitsu.com>)
Responses Re: Use the enum value CRS_EXPORT_SNAPSHOT instead of "0"
Re: Use the enum value CRS_EXPORT_SNAPSHOT instead of "0"
List pgsql-hackers
Tree view 
On Fri, Jun 16, 2023 at 3:10 PM Wei Wang (Fujitsu)
<wangw.fnst@fujitsu.com> wrote:
>
> Hi,
>
> In the function WalReceiverMain, when the function walrcv_create_slot is called,
> the fourth parameter is assigned the value "0" instead of the enum value
> "CRS_EXPORT_SNAPSHOT". I think it would be better to use the corresponding enum
> value.

The walreceiver process doesn't use CRS_EXPORT_SNAPSHOT actually,
right? I think replacing it with CRS_EXPORT_SNAPSHOT would rather
confuse me

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: add non-option reordering to in-tree getopt_long
Next
From: Quan Zongliang
Date:
Subject: Incorrect estimation of HashJoin rows resulted from inaccurate small table statistics