On Sat, Mar 20, 2021 at 3:52 AM Andres Freund <andres@anarazel.de> wrote:
>
> - If max_replication_slots was lowered between a restart,
> pgstat_read_statfile() will happily write beyond the end of
> replSlotStats.
I think we cannot restart the server after lowering
max_replication_slots to a value less than the number of replication
slots actually created on the server. No?
>
> - pgstat_reset_replslot_counter() acquires ReplicationSlotControlLock. I
> think pgstat.c has absolutely no business doing things on that level.
Agreed.
>
> - PgStat_ReplSlotStats etc use slotname[NAMEDATALEN]. Why not just NameData?
That's because we followed other definitions in pgstat.h that use
char[NAMEDATALEN]. I'm okay with using NameData.
>
> - pgstat_report_replslot() already has a lot of stats parameters, it
> seems likely that we'll get more. Seems like we should just use a
> struct of stats updates.
Agreed.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
