On Mon, Sep 28, 2026 at 9:13 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 26 Sep 2026, at 06:37, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
> > On Fri, Sep 25, 2026 at 5:32 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> >> As for the 0001 patch, it looks good to me.
>
> Agreed, +1 pn 0001.
>
> > Please find the attached v4 patches. 0002 remains the same.
>
> Regarding 0002, ISTM that it will be stable but we could also just commit to
> master and hold off on REL_19_STABLE for now. Once proven it can be back-
> patched even post GA as it is test-only. That could give us more time while
> reducing the risk of unstable tests this very late in the cycle.
Agreed.
Daniel, are you planning to push the 0001 patch separately from the
tests? I will be attending Postgres Summit US 2026 this week, so I can
push 0001 early next week instead just in case the buildfarm turns red
and requires monitoring.
> comments on 0002:
Aside from these comments, I think we could simplify the tests by
introducing a boolean variable, say, leader_participates that controls
whether the leader participates in parallel index vacuuming. It would
default to true, but we could toggle it off via an injection point.
When set to false, the leader would vacuum parallel-unsafe indexes but
skip parallel-safe ones.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
