On Fri, Mar 29, 2024 at 8:48 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Sawada-san,
>
> > Agreed.
> >
> > I think the patch is in good shape. I'll push the patch with the
> > suggestion next week, barring any objections.
>
> Thanks for working on this. Agreed it is committable.
> Few minor comments:
Thank you for the comments!
>
> ```
> + * Either txn or change must be non-NULL at least. We update the memory
> + * counter of txn if it's non-NULL, otherwise change->txn.
> ```
>
> IIUC no one checks the restriction. Should we add Assert() for it, e.g,:
> Assert(txn || change)?
Agreed to add it.
>
> ```
> + /* make sure enough space for a new node */
> ...
> + /* make sure enough space for a new node */
> ```
>
> Should be started with upper case?
I don't think we need to change it. There are other comments in the
same file that are one line and start with lowercase.
I've just submitted the updated patches[1]
Regards,
[1]
https://www.postgresql.org/message-id/CAD21AoA6%3D%2BtL%3DbtB_s9N%2BcZK7tKz1W%3DPQyNq72nzjUcdyE%2BwZw%40mail.gmail.com
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com