Re: Use allocation macros in the logical replication code - Mailing list pgsql-hackers

On Tue, Feb 3, 2026 at 9:40 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Wed, Feb 4, 2026 at 1:47 PM Hayato Kuroda (Fujitsu)
> <kuroda.hayato@fujitsu.com> wrote:
> >
> > Dear Peter,
> >
> > Thanks for the patch. I have one comment for the patch:
> > ```
> > @@ -836,8 +836,9 @@ SnapBuildAddCommittedTxn(SnapBuild *builder, TransactionId xid)
> >                 elog(DEBUG1, "increasing space for committed transactions to %u",
> >                          (uint32) builder->committed.xcnt_space);
> >
> > -               builder->committed.xip = repalloc(builder->committed.xip,
> > -                                                                                 builder->committed.xcnt_space *
sizeof(TransactionId));
> > +               builder->committed.xip = repalloc_array(builder->committed.xip,
> > +                                                       TransactionId,
> > +                                                       builder->committed.xcnt_space);
> > ```
> >
> > Number of tabs seems not to enough here. Other than that LGTM.
> >
>
> Thanks for the feedback. Now I have run pg_indent on all the patched files.
>
> PSA v2

Thank you for the patch!

The patch looks good to me. I'll push it, barring objections.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com