Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation - Mailing list pgsql-hackers

On Wed, Jul 29, 2026 at 3:21 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Jul 27, 2026 at 10:10 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > Agreed and pushed the 0001 patch.
> >
> > I've updated the comments in the previous-0002 patch, please review it.
> >
>
> In the comments you mentioned 'already-visible slot' as follows: "Our
> already-visible slot guarantees that this check doesn't miss ..." but
> we normally don't use visibility term for slots (it is used primarily
> for tuples). I think you mean to say that its in_use flag is set, I
> tried to slightly modify that part of the comment in the attached.
> See, if that looks okay to you.

Fair point. I've updated the comments and commit message not to use
the visibility term.

> Apart from that, I ran the added test on my Windows machine and it
> failed, attached find the required log.

Thank you for testing it. It seems to be reproducible also on CI, and
I believe I've fixed the issue.

I've attached the patch. Please review it.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com