Re: Issue with pg_stat_subscription_stats - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Issue with pg_stat_subscription_stats
Date
Msg-id CAD21AoBMmO-vdm5-as2jnazUxOQnp6QjOc3hU87j1C3fmCpdRA@mail.gmail.com
Whole thread Raw
In response to Re: Issue with pg_stat_subscription_stats  (Andres Freund <andres@anarazel.de>)
Responses Re: Issue with pg_stat_subscription_stats
List pgsql-hackers
On Wed, Jul 6, 2022 at 10:48 AM Andres Freund <andres@anarazel.de> wrote:
>
> On 2022-07-06 10:25:02 +0900, Masahiko Sawada wrote:
> > > I think most of this could just be pgstat_reset_entry().
> >
> > I think pgstat_reset_entry() doesn't work for this case as it skips
> > resetting the entry if it doesn't exist.
>
> True - but a pgstat_get_entry_ref(create = true); pgstat_reset_entry(); would
> still be shorter?

Indeed. I've updated the patch.

Regards,

--
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: pg_rewind: warn when checkpoint hasn't happened after promotion
Next
From: Noah Misch
Date:
Subject: Re: First draft of the PG 15 release notes