RepOrigin vs. replorigin - Mailing list pgsql-hackers

From Masahiko Sawada
Subject RepOrigin vs. replorigin
Date
Msg-id CAD21AoBDgm3hDqUZ+nqu=ViHmkCnJBuJyaxG_yvv27BAi2zBmQ@mail.gmail.com
Whole thread Raw
Responses Re: RepOrigin vs. replorigin
List pgsql-hackers
Hi all,

While reading the code in origin.c, I found the inconsistent use of
RepOrigin and replorigin (with an 'l') quite confusing -- especially
when trying to determine names for new functions or variables. For
instance,

- RepOriginId
- InvalidRepOriginId

- RM_REPLORIGIN_ID
- XLOG_REPLORIGIN_{SET|DROP}
- replorigin_session_origin
- replorigin_session_xxx() functions

Is there a conventional rule for choosing one over the other depending
on context? Or should we consider unifying these naming conventions?"

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: pg_upgrade: optimize replication slot caught-up check
Next
From: Mihail Nikalayeu
Date:
Subject: Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY