Tab-comletion for RLS - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Tab-comletion for RLS
Date
Msg-id CAD21AoAz4SQMK-E=VVoMViMa=btABNXY==d0fv38zGPRB98AMQ@mail.gmail.com
Whole thread Raw
Responses Re: Tab-comletion for RLS  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Hi all,

I found some lacks of tab-completion for RLS in 9.5.

* ALTER POLICY [TAB]
I expected to appear the list of policy name, but nothing is appeared.

* ALTER POLICY hoge_policy ON [TAB]
I expected to appear the list of table name related to specified policy, but all table names are appeared. 

* ALTER POLICY ... ON ... TO [TAB]
I expected to appear { role_name | PUBLIC | CURRENT_USER | SESSION_USER }, but only role_name and PUBLIC are appeared.
Same problem is exists in
"
CREATE POLICY ... ON ... TO [TAB]
"
.

#1 and #2 problems are exist in 9.5 or later, but #3 is exist in only 9.5 because it's unintentionally fixed by 2f8880704a697312d8d10ab3a2ad7ffe4b5e3dfd commit.
I think we should apply the necessary part of this commit for 9.5 as well, though?

Attached patches are:​
* 000_fix_tab_completion_rls.patch
  fixes #1, #2 problem, and is for master branch and REL9_5_STABLE.​
* 001_fix_tab_completion_rls_for_95.patch
  fixes #3 problem, and is for only REL9_5_STABLE.

​Regards,​

--
Masahiko Sawada

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Error with index on unlogged table
Next
From: Simon Riggs
Date:
Subject: Re: [PROPOSAL] Backup and recovery of pg_statistic