Re: [HACKERS] Fix a typo in snapmgr.c - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: [HACKERS] Fix a typo in snapmgr.c
Date
Msg-id CAD21AoAwvOCtU5eJROnydVqsHwP9MQ4VEdhm0UPXuLCPL2DrRA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Fix a typo in snapmgr.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, May 8, 2017 at 10:12 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Simon Riggs <simon@2ndquadrant.com> writes:
>> So rearranged code a little to keep it lean.
>
> Didn't you break it with that?  As it now stands, the memcpy will
> copy the nonzero value.
>

Right, I'd missed it. That code should be placed before first memcpy.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] PG 10 release notes
Next
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] PG 10 release notes