Re: Fix incorrect buffer lock description in pg_visibility comment - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Fix incorrect buffer lock description in pg_visibility comment
Date
Msg-id CAD21AoAqTt_+4r7cPsnGG6pB8y7As6eqbjJTENFGzAmuVMQPXg@mail.gmail.com
Whole thread Raw
In response to Fix incorrect buffer lock description in pg_visibility comment  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
Hi,

On Tue, Dec 23, 2025 at 6:18 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
> Hi Hackers,
>
> While reviewing the patch [1], though I couldn’t raise a comment for it, I noticed a comment error in the file
pg_visibility.c,where a buffer lock is held in shared mode but the code comment mentioned exclusive mode. I am filing a
smallpatch to correct the comment. 
>
> I only changed "exclusively" to "shared", the format changed was done by pgindent.

Yeah, it seems like a typo since the first commit of pg_visiblity,
e472ce9624e0. I think we can backpatch it to all supported versions.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Fixing some ancient errors in hash join costing
Next
From: Matthias van de Meent
Date:
Subject: Re: lsyscache: free IndexAmRoutine objects returned by GetIndexAmRoutineByAmId()