On Tue, Aug 17, 2021 at 12:00 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Thu, Aug 12, 2021 at 3:54 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > I've attached the updated patches. FYI I've included the patch
> > (v8-0005) that fixes the assertion failure during shared fileset
> > cleanup to make cfbot tests happy.
> >
>
Thank you for the comment!
> Another comment on the 0001 patch: as there is now a mix of setting
> "apply_error_callback_arg" members directly and also through inline
> functions, it might look better to have it done consistently with
> functions having prototypes something like the following:
>
> static inline void set_apply_error_context_rel(LogicalRepRelMapEntry *rel);
> static inline void reset_apply_error_context_rel(void);
> static inline void set_apply_error_context_attnum(int remote_attnum);
It might look consistent, but if we do that, we will end up needing
functions every field to update when we add new fields to the struct
in the future?
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
