Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT
Date
Msg-id CAD21AoAjRQ8y4ewZuJq6EByW5QaGcHY0i9=znUatEnhVvJDoYg@mail.gmail.com
Whole thread Raw
In response to Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Tue, Nov 19, 2024 at 1:14 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 19/11/2024 01:20, Masahiko Sawada wrote:
> > I realized that building test_radixtree.c with TEST_SHARED_RT fails
> > because it eventually sets RT_SHMEM when #include'ing radixtree.h but
> > it's missing some header files to include. I've attached a patch to
> > include necessary header files in radixtree.h to make it
> > self-contained.
>
> If those includes are only needed when RT_SHMEM is defined, I suggest
> they should be guarded by #ifdef RT_SHMEM, per Peter E's IWYU efforts
> lately.

Indeed. I'll incorporate it in the next version.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT
Next
From: Bruce Momjian
Date:
Subject: Re: Statistics Import and Export