Re: Dropping publication breaks logical replication - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Dropping publication breaks logical replication
Date
Msg-id CAD21AoASrPkxcPxOzsQn-gMAbM-iJH-f-GyH7e18pA79AHzs2A@mail.gmail.com
Whole thread Raw
In response to Re: Dropping publication breaks logical replication  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Fri, Aug 8, 2025 at 5:48 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Aug 8, 2025 at 5:19 PM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> >
> > On Tue, Aug 5, 2025 at 9:50 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >
> > > On Fri, Aug 1, 2025 at 5:06 PM Ashutosh Bapat
> > > <ashutosh.bapat.oss@gmail.com> wrote:
> > > >
> > > > On Fri, Aug 1, 2025 at 4:03 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > > >
> > > > > Now, seeing this report, it seems the customer(s) are probably okay to
> > > > > skip a missing publication and let replication continue. So, we should
> > > > > consider backpatching this change but it would be better if few more
> > > > > people can share their opinion on this matter.
> > > >
> > > > Including Tomas for his opinion. Who else do you think can provide an
> > > > opinion based on experience?
> > > >
> > >
> > > I don't have any particular names in mind but Dilip and Sawada-San
> > > names are listed as reviewers in the commit [1], so it would be good
> > > to see what are their thoughts on this.
> > >
> > > Please note that this behavior is from the time logical replication
> > > was introduced, so we need to be a bit careful in changing the
> > > behavior in backbranches.
> >
> > Agreed.
> >
> > Only Dilip has expressed an opinion so far. Haven't heard from others,
> > so can't guess what their opinions are.
> >
>
> Yeah, let's wait for a few more days. Even if we decide to backpatch
> it, let's target the next minor release.

I'm personally hesitant to backpatch this change. I'm not sure if
there are any users who aware of this behavior and depend on it, but
it seems to me that for users who update to a new minor version having
this change, the problem will simply change from that replication
stops due to missing publications to that replication can continue but
they will almost silently lose some changes (users often don't see
warnings in server logs). I guess dealing with the latter problem
would be more difficult.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Adding basic NUMA awareness
Next
From: Tomas Vondra
Date:
Subject: Re: index prefetching