Request a Demo
Home   >   mailing lists

[PATCH v1] psql: complete ALTER ROLE ... IN DATABASE ... RESET - Mailing list pgsql-hackers

From Xianbin Zhu
Subject [PATCH v1] psql: complete ALTER ROLE ... IN DATABASE ... RESET
Date
Msg-id CAD-rTHmcFSsG8N14G8BZeGSgY94v=N0NC-CHfnZegfYzEYnNQw@mail.gmail.com
Whole thread
In response to [PROPOSAL] psql tab completion: support ALTER ROLE ... IN DATABASE ... RESET  (Xianbin Zhu <xianbin.aaronzhu@gmail.com>)
List pgsql-hackers
Tree view
Hi hackers,

As discussed, here's a patch to add psql tab-completion support for:

ALTER ROLE/USER <name> IN DATABASE <db> RESET ...

Changes:
- Add completion path for "... IN DATABASE <db> RESET"
- Offer GUC names and ALL after RESET
- Add tab-completion test coverage in src/bin/psql/t/010_tab_completion.pl

Testing:
- make -j8
- make check (all tests passed in my environment)

Patch attached.

Thanks,
xianbinzhu

On Sun, Mar 29, 2026 at 2:50 PM Xianbin Zhu <xianbin.aaronzhu@gmail.com> wrote:
Hi hackers,

I'd like to work on a small psql tab-completion improvement.

Problem:
psql currently has a missing completion path for:
ALTER ROLE <role> IN DATABASE <db> RESET ...

There is an in-code TODO marker for this case in src/bin/psql/tab-complete.in.c.

Proposal:
- Add completion support after "... IN DATABASE <db> RESET"
- Reuse existing completion behavior/style used by ALTER ROLE ... RESET
- Add regression coverage in src/bin/psql/t/010_tab_completion.pl

Non-goals:
- No backend behavior changes
- No SQL grammar changes

If this direction looks good, I can send a patch.

Thanks,
xianbinzhu
Attachment

pgsql-hackers by date:

Previous
From: Xianbin Zhu
Date:
Subject: [PROPOSAL] psql tab completion: support ALTER ROLE ... IN DATABASE ... RESET
Next
From: Dean Rasheed
Date:
Subject: Re: Allow to collect statistics on virtual generated columns