Re: Compressed TOAST Slicing - Mailing list pgsql-hackers

From Paul Ramsey
Subject Re: Compressed TOAST Slicing
Date
Msg-id CACowWR2qvuG88JuYAqbAeD4VtN6CtXucqEGReBapr2Dbev_mUw@mail.gmail.com
Whole thread Raw
In response to Re: Compressed TOAST Slicing  (Rafia Sabih <rafia.sabih@enterprisedb.com>)
Responses Re: Compressed TOAST Slicing  (Andres Freund <andres@anarazel.de>)
Re: Compressed TOAST Slicing  (Simon Riggs <simon@2ndquadrant.com>)
List pgsql-hackers
On Sun, Dec 2, 2018 at 7:03 AM Rafia Sabih <rafia.sabih@enterprisedb.com> wrote:
>
> The idea looks good and believing your performance evaluation it seems
> like a practical one too.

Thank you kindly for the review!

> A comment explaining how this check differs for is_slice case would be helpful.
> Looks like PG indentation is not followed here for n.

I have attached updated patches that add the comment and adhere to the Pg variable declaration indentation styles,
ATB!
P

--
Paul Ramsey

Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Connections hang indefinitely while taking a gin index's LWLockbuffer_content lock
Next
From: Peter Geoghegan
Date:
Subject: Re: Connections hang indefinitely while taking a gin index's LWLockbuffer_content lock