Re: [PATCH] postgres_fdw extension support - Mailing list pgsql-hackers

From Paul Ramsey
Subject Re: [PATCH] postgres_fdw extension support
Date
Msg-id CACowWR0g1+i+MGtVaR1pySZKbuA-fKsvA6uQTa=SVs7sL2SCqw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] postgres_fdw extension support  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] postgres_fdw extension support  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Tue, Oct 6, 2015 at 6:55 AM, Andres Freund <andres@anarazel.de> wrote:
> On 2015-10-06 06:42:17 -0700, Paul Ramsey wrote:
>> *sigh*, no you’re not missing anything. In moving to the cache and
>> marking things just as “shippable” I’ve lost the test that ensures
>> they are shippable for this *particular* server (which only happens in
>> the lookup stage). So yeah, the cache will be wrong in cases where
>> different servers have different extension opti ons.
>
> Should be easy enough to fix - just add the server's oid to the key.
>
> But I guess you're already on that.

Yep, just a big chastened :)
Thanks for the catch, here's the patch,
P

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [PATCH] postgres_fdw extension support
Next
From: YUriy Zhuravlev
Date:
Subject: Re: No Issue Tracker - Say it Ain't So!