Postgres Pro
Downloads
Home   >   mailing lists

Re: TestForOldSnapshot() seems to be in the wrong place - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: TestForOldSnapshot() seems to be in the wrong place
Date
Msg-id CACjxUsMY4-mnW72fTC3yW0R0beEL5vEpj+OaPUEAb__V=NcGTw@mail.gmail.com
Whole thread Raw
In response to TestForOldSnapshot() seems to be in the wrong place  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Tree view 
On Fri, Jan 18, 2019 at 3:13 PM Andres Freund <andres@anarazel.de> wrote:

> TestForOldSnapshot()

> to me it seems wrong from a layering POV to have this in
> bufmgr.[ch]. Due to the inline functions this makes bufmgr.h have a
> dependency on snapmgr.h and tqual.h, which to me seems wrong from a
> layer POV.  Why isn't this declared in snapmgr.h or a new header file?

I will take a look.

-- 
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists
Next
From: Tom Lane
Date:
Subject: Re: Rare SSL failures on eelpout