> I ran it through pgindent to fix some whitespace issues and added
> another test for the filter option, based on the test case you added.
Thank you for addressing those whitespaces issues and adding more tests. I appreciate your attention to detail and will certainly be more vigilant in future.
> I'm marking this ready-for-commit (which I'll probably do myself in a
> day or two, unless anyone else claims it first).
Thank you very much, this marks my first contribution to the open-source community, and I'm enthusiastic about making further meaningful contributions to PostgreSQL in the future.
> LGTM too from a read through. I did notice a few mistakes in the --filter
> documentation portion for other keywords but that's unrelated to this patch,
> will fix them once this is in to avoid conflicts.
Thanks Daniel for your review. It's gratifying to see that my patch not only introduced the intended feature but also brought other minor mistakes to light.
Regards
Ayush Vatsa
Amazon Web services (AWS)
> On 19 Mar 2024, at 12:19, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
> I'm marking this ready-for-commit (which I'll probably do myself in a
> day or two, unless anyone else claims it first).
LGTM too from a read through. I did notice a few mistakes in the --filter
documentation portion for other keywords but that's unrelated to this patch,
will fix them once this is in to avoid conflicts.
--
Daniel Gustafsson
