Hi Tom,
You are right, and the fault is entirely mine. Sorry for the noise.
What was different about my installation: a stale tmp_install. The
postgres binary the isolation tests were actually executing was dated
20 September, four days old, while the expected files were being read
from a current checkout. So the server predates 85f55534e80 and does
not contain the fix, but the expected output already contained the new
WHEN NOT MATCHED BY SOURCE permutations that commit added.
What I reported as a regression is therefore the original bug that
commit fixes, not a new one. The all-NULL insert is precisely the
behaviour it corrects. I should have caught that from the symptom
alone.
A from-scratch build directory, same tree, same machine, same
configure options:
build (stale tmp_install, binary dated Sep 20) merge-delete fails
build-clean (fresh meson setup, same commit) 133/133 pass
So there is nothing wrong with the commit, and the buildfarm is right.
Apologies to Dean and Tender for the false alarm.
Regards,
Trakshan Mishra
