Request a Demo
Home   >   mailing lists

Re: [PATCH v2] Avoid internal error for invalid interval typmods - Mailing list pgsql-hackers

From Feng Wu
Subject Re: [PATCH v2] Avoid internal error for invalid interval typmods
Date
Msg-id CACK3muqtGkxD14bxbUL8wf1L3NVFpwky_-kxLkMw+ZK2T7757A@mail.gmail.com
Whole thread
Responses Re: [PATCH v2] Avoid internal error for invalid interval typmods
List pgsql-hackers
Tree view 
Hi Haibo,

Thanks for reviewing.

I agree that the SQL-callable pg_catalog.interval(interval, int4) path is the
important case to cover here.  The v1 test was already exercising that direct
call, but it used a DO block intentionally so that the regression test checks
the SQLSTATE is invalid_parameter_value, rather than only matching the error
message text.

In v2, I kept that structure and updated the test comment to make this clearer.

Regards,
Feng
Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Centralised architecture detection
Next
From: Tender Wang
Date:
Subject: Re: Fix HAVING-to-WHERE pushdown with mismatched operator families