Postgres Pro
Downloads
Home   >   mailing lists

Re: read stream on amcheck - Mailing list pgsql-hackers

From jian he
Subject Re: read stream on amcheck
Date
Msg-id CACJufxH8eK_yEk3Sn=W+zfvQEp8sCDWfwqcsLd8A7GiEhZF7NQ@mail.gmail.com
Whole thread Raw
In response to Re: read stream on amcheck  (Kirill Reshke <reshkekirill@gmail.com>)
List pgsql-hackers
Tree view 
On Fri, Jan 3, 2025 at 1:53 AM Matheus Alcantara
<matheusssilv97@gmail.com> wrote:
>
>
> Yeap, I agree. Attached a v2 fixed.
>

hi. some minor issue i found.

+#include "storage/block.h"
no need, since "#include "storage/bufmgr.h" already included it.

do we need to add ``CHECK_FOR_INTERRUPTS()`` in heapam_read_stream_next_block?

heapam_read_stream_next_block_private need add to
src/tools/pgindent/typedefs.list

overall, it looks good to me.

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation
Next
From: Ashutosh Bapat
Date:
Subject: Re: Test to dump and restore objects left behind by regression