Re: pg_restore --no-policies should not restore policies' comment - Mailing list pgsql-hackers

From jian he
Subject Re: pg_restore --no-policies should not restore policies' comment
Date
Msg-id CACJufxGbCFdTnuaHOJe463UCnE-WE6XNRdE4dNSZrpKMyoagkQ@mail.gmail.com
Whole thread Raw
In response to Re: pg_restore --no-policies should not restore policies' comment  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Tue, Aug 26, 2025 at 7:43 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> >
> > summary of attached patch:
>
> Thanks for the patches!
>
> > 01: make pg_restore not restore comments if comments associated
> > objects are excluded.
>
> > TODO: need perl tests
>
> How about adding tests for pg_restore --no-policies in 002_pg_dump.pl,
> as in the attached patch?
>

it works fine on my local linux machine.

> Since --no-publications and --no-subscriptions have been around for a long time,
> while --no-policies was added in v18, I wonder if it makes sense to first fix
> the publications and subscriptions cases (and add tests for them) and back-patch
> to all supported versions. Then we can handle the policies case and
> back-patch it
> only to v18. Does that sound reasonable?
>
works for me.



pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Re: Adding REPACK [concurrently]
Next
From: Masahiko Sawada
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart