src/test/modules/test_regex/test_regex.c typo issue - Mailing list pgsql-hackers

From jian he
Subject src/test/modules/test_regex/test_regex.c typo issue
Date
Msg-id CACJufxGBHg-tcZ3EkCaPM_uH9Q_q6cJzdp+K-0pTY=kmoyC30g@mail.gmail.com
Whole thread Raw
Responses Re: src/test/modules/test_regex/test_regex.c typo issue
List pgsql-hackers

Hi,
in src/test/modules/test_regex/test_regex.c

/* Report individual info bit states */ for (inf = infonames; inf->bit != 0; inf++) { if (cpattern->re_info & inf->bit) { if (flags->info & inf->bit) elems[nresults++] = PointerGetDatum(cstring_to_text(inf->text)); else { snprintf(buf, sizeof(buf), "unexpected %s!", inf->text); elems[nresults++] = PointerGetDatum(cstring_to_text(buf)); } } else { if (flags->info & inf->bit) { snprintf(buf, sizeof(buf), "missing %s!", inf->text); elems[nresults++] = PointerGetDatum(cstring_to_text(buf)); } } }

I think "expected" should be replaced with "missing".
the "missing" should be replaced with "expected".

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Remove unused code related to iso-8859-1 type
Next
From: Tom Lane
Date:
Subject: Re: src/test/modules/test_regex/test_regex.c typo issue