Re: bug, ALTER TABLE call ATPostAlterTypeCleanup twice for the same relation - Mailing list pgsql-hackers

From jian he
Subject Re: bug, ALTER TABLE call ATPostAlterTypeCleanup twice for the same relation
Date
Msg-id CACJufxG1Qwj=mHHZNT6L=7g9MeizbD3B+1=HN1TDvv4M92pTEQ@mail.gmail.com
Whole thread Raw
In response to bug, ALTER TABLE call ATPostAlterTypeCleanup twice for the same relation  (jian he <jian.universality@gmail.com>)
List pgsql-hackers
On Sat, Sep 27, 2025 at 5:54 PM jian he <jian.universality@gmail.com> wrote:
>
> While at it, maybe we can also polish the comment below in ATRewriteCatalogs.
>             /*
>              * After the ALTER TYPE or SET EXPRESSION pass, do cleanup work
>              * (this is not done in ATExecAlterColumnType since it should be
>              * done only once if multiple columns of a table are altered).
>              */
> but I didn't do it...

I add one sentence:
Note: ATPostAlterTypeCleanup must be called only once per relation!

I also polished the regress tests.

Attachment

pgsql-hackers by date:

Previous
From: Greg Burd
Date:
Subject: Re: [PATCH] Add tests for Bitmapset
Next
From: Amit Kapila
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication