Request a Demo
Home   >   mailing lists

Re: [PATCH] Fix duplicate errmsg in ALTER TABLE SPLIT PARTITION - Mailing list pgsql-hackers

From jian he
Subject Re: [PATCH] Fix duplicate errmsg in ALTER TABLE SPLIT PARTITION
Date
Msg-id CACJufxFw7jy=czO4CqS2-zzo_9xymzW+fi4n1QGFeE87AtbOWA@mail.gmail.com
Whole thread
In response to Re: [PATCH] Fix duplicate errmsg in ALTER TABLE SPLIT PARTITION  (Ayush Tiwari <ayushtiwari.slg01@gmail.com>)
Responses Re: [PATCH] Fix duplicate errmsg in ALTER TABLE SPLIT PARTITION
List pgsql-hackers
Tree view 
On Wed, Apr 22, 2026 at 7:06 PM Ayush Tiwari
<ayushtiwari.slg01@gmail.com> wrote:
>
> Attaching v3 patch.
>
hi.

V3 looks good to me.
The error message already conveyed the failure reasoning.
Just adding comment `-- ERROR` to partition_merge.sql, partition_split.sql
is enough, I think.

- errdetail("lower bound of partition \"%s\" is not equal to the upper
bound of partition \"%s\"",
+ errdetail("Lower bound of partition \"%s\" is not equal to upper
bound of partition \"%s\".",
   second_name->relname, first_name->relname),
- errhint("ALTER TABLE ... MERGE PARTITIONS requires the partition
bounds to be adjacent."),

The errdetail already explicitly explains the failure reason, removing
the errhint should be fine, I think.
I noticed you removed "the", I'm not sure if that's okay since I am
not a native English speaker.



--
jian
https://www.enterprisedb.com/

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: The bogus calls in remove_self_join_rel()
Next
From: David Rowley
Date:
Subject: Re: The bogus calls in remove_self_join_rel()