Re: pg_dumpall --roles-only interact with other options - Mailing list pgsql-hackers

From jian he
Subject Re: pg_dumpall --roles-only interact with other options
Date
Msg-id CACJufxFv1Tixecxk78hOO21BgT4mo36MZxH8HFfkP-jGMxm4NA@mail.gmail.com
Whole thread
In response to Re: pg_dumpall --roles-only interact with other options  (Zsolt Parragi <zsolt.parragi@percona.com>)
Responses Re: pg_dumpall --roles-only interact with other options
List pgsql-hackers
On Fri, Feb 6, 2026 at 5:36 PM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>
> Please see the attached tap test case. It works with the current
> master branch, and fails with the patch. Basically my expectation is
> that if we use dumpall --schema-only, we should be able to restore it
> without errors, except for one error for the already existing
> postgres/current user which it ignores.
>
> I also found one more issue/behavior change: --no-schema --clean now
> generates DROP statements (roles, tablespaces, databases), while
> previously it didn't.

hi.

It would be better to simply reject the CONFLICT ONLY option and keep the rest
of the logic same as the HEAD. That way, we avoid any surprising behavior.
IMHO.

Please check attached v5.


--
jian
https://www.enterprisedb.com/

Attachment

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: Skipping schema changes in publication
Next
From: Michael Paquier
Date:
Subject: Re: Add expressions to pg_restore_extended_stats()