Re: Infinite Interval - Mailing list pgsql-hackers

From jian he
Subject Re: Infinite Interval
Date
Msg-id CACJufxFfvkO_bxh_JopH3S70MABdOPRqihv1_pSn0WE3gxwESA@mail.gmail.com
Whole thread Raw
In response to Re: Infinite Interval  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: Infinite Interval
List pgsql-hackers
> On Wed, 20 Sept 2023 at 15:00, Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> >
> > 0005 - Refactored Jian's code fixing window functions. Does not
> > contain the changes for serialization and deserialization. Jian,
> > please let me know if I have missed anything else.
> >

attached serialization and deserialization function.


>
> Also, in do_interval_discard(), this seems a bit risky:
>
> +        neg_val.day = -newval->day;
> +        neg_val.month = -newval->month;
> +        neg_val.time = -newval->time;
>

we already have interval negate function, So I changed to interval_um_internal.
based on 20230920 patches. I have made the attached changes.

The serialization do make big difference when configure to parallel mode.

Attachment

pgsql-hackers by date:

Previous
From: "Lepikhov Andrei"
Date:
Subject: Re: Comment about set_join_pathlist_hook()
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: CI: Unfamiliar error while testing macOS