stale comment in struct AlteredTableInfo - Mailing list pgsql-hackers

From jian he
Subject stale comment in struct AlteredTableInfo
Date
Msg-id CACJufxEvw496SK=nmvxOL0SQYBPhrsnad1DUj6cPs17cvvDSMQ@mail.gmail.com
Whole thread
List pgsql-hackers
HI.

{
/* Objects to rebuild after completing ALTER TYPE operations */
List   *changedConstraintOids; /* OIDs of constraints to rebuild */
List   *changedConstraintDefs; /* string definitions of same */
List   *changedIndexOids; /* OIDs of indexes to rebuild */
List   *changedIndexDefs; /* string definitions of same */
char   *replicaIdentityIndex; /* index to reset as REPLICA IDENTITY */
char   *clusterOnIndex; /* index to use for CLUSTER */
List   *changedStatisticsOids; /* OIDs of statistics to rebuild */
List   *changedStatisticsDefs; /* string definitions of same */
List   *changedStatisticsOwners; /* owners of same */
} AlteredTableInfo;

Comment
/* Objects to rebuild after completing ALTER TYPE operations */
should be
/* Objects to rebuild after completing ALTER TYPE or SET EXPRESSION
operations */

Since these objects apply to ALTER COLUMN SET EXPRESSION too.



--
jian
https://www.enterprisedb.com/



pgsql-hackers by date:

Previous
From: Khoa Nguyen
Date:
Subject: Re: HASH INDEX builds seems confused
Next
From: shihao zhong
Date:
Subject: Re: Add a permission check to pg_stat_get_backend_subxact()