Re: CREATE TABLE LIKE INCLUDING TRIGGERS - Mailing list pgsql-hackers

From jian he
Subject Re: CREATE TABLE LIKE INCLUDING TRIGGERS
Date
Msg-id CACJufxEKK44FtxiShTZtPtCehwm47k5wB+RobuRCUJRa_b0owg@mail.gmail.com
Whole thread Raw
In response to Re: CREATE TABLE LIKE INCLUDING TRIGGERS  (Zsolt Parragi <zsolt.parragi@percona.com>)
Responses Re: CREATE TABLE LIKE INCLUDING TRIGGERS
List pgsql-hackers
On Fri, Feb 6, 2026 at 10:49 PM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>
> This looks good to me, I only have two minor comments:
>
> 1. The test should drop main_table1 and some_t1
>
> 2. there's a missing word in a comment (do -> to do)
>
> + char    *trigcomment; /* comment to apply to trigger, or NULL */
> + bool transformed; /* true means no need do parse analysis for *
> + * whenClause */

hi.
The attached have addressed these two points.

I still keep two separate patches, in case there are differing opinions about
whether to copy the old table’s trigger tgenabled to the new table.
Squashing them into a single patch is quite straightforward.



--
jian
https://www.enterprisedb.com/

Attachment

pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: Add expressions to pg_restore_extended_stats()
Next
From: Richard Guo
Date:
Subject: Re: Convert NOT IN sublinks to anti-joins when safe