Re: IPC/MultixactCreation on the Standby server - Mailing list pgsql-hackers

From Maxim Orlov
Subject Re: IPC/MultixactCreation on the Standby server
Date
Msg-id CACG=ezbtm+LOzEMyLX7rzGcAv3ez3F6nNpSJjvZeMzed0Oe6Pw@mail.gmail.com
Whole thread Raw
In response to Re: IPC/MultixactCreation on the Standby server  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: IPC/MultixactCreation on the Standby server
List pgsql-hackers

On Fri, 28 Nov 2025 at 22:51, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

I moved the wraparound test to a separate test file and commit. More
test coverage is good, but it's quite separate from the bugfix and the
wraparound related test shares very little with the other test. The
wraparound test needs a little more cleanup: use plain perl instead of
'dd' and 'rm' for the file operations, for example. (I did that with the
tests in the 64-bit mxoff patches, so we could copy from there.)

It's good that the test was added. But it seems like it could be
improved a bit. The problem is, it only runs successfully with a
standard block size. Plus, the comment about the number of bytes was a
bit unclear, for my taste. PFA patch, it should make this test pass
with different block sizes. 

--
Best regards,
Maxim Orlov.
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: More const-marking cleanup
Next
From: Heikki Linnakangas
Date:
Subject: Re: commented out code