I did a look at the patch, and it seems to be in a good condition.
It implements declared functionality with no visible defects.
As for test, I think it is possible to implement "signals" case in tap tests. But let the actual commiter decide does it worth it or not.
-- Best regards,
Maxim Orlov.
