Re: POC: make mxidoff 64 bits - Mailing list pgsql-hackers

From Maxim Orlov
Subject Re: POC: make mxidoff 64 bits
Date
Msg-id CACG=ezaVcG-uoD+U1D-6ELe3H5zqQM0CsC5ts6yA_u=553+EXg@mail.gmail.com
Whole thread Raw
In response to Re: POC: make mxidoff 64 bits  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers

On Thu, 11 Dec 2025 at 10:58, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

That's a great question and I've been wondering about it myself. It goes
all the way to the initial commit where multixacts were introduced, and
I don't see any particular reason for it even back then. Even in the
very first version of multixact.c, IMO it would've been simpler to have
the writer handle the wraparound.

+1 This code is quite old. I don't see any particular reason for doing
it that way. Unfortunately, we were unable to prove the absence of
something, namely errors, in this instance. But there were no obvious
statements on why it should be in this manner. So, for me, it's much
clearer to increment and handle wraparound in one place rather
than spread it across multiple calls in the module.

--
Best regards,
Maxim Orlov.

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: failed NUMA pages inquiry status: Operation not permitted
Next
From: jian he
Date:
Subject: regex Quantifiers {m,n}, m can be negative, n greater than 255