Re: Patch for migration of the pg_commit_ts directory - Mailing list pgsql-hackers

From Maxim Orlov
Subject Re: Patch for migration of the pg_commit_ts directory
Date
Msg-id CACG=ezaFdL4EM8bdrHTRVHt5BmxxWGXcPiDr6Qm00Qj+S_Y+vQ@mail.gmail.com
Whole thread Raw
In response to Re: Patch for migration of the pg_commit_ts directory  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers

On Thu, 2 Oct 2025 at 11:49, Amit Kapila <amit.kapila16@gmail.com> wrote:
 When we try to
copy slots and the wal_level on the new server is minimal, we error
out, so shouldn't we do the same here and error_out if
track_commit_timestamp is not enabled and we have some valid commit_ts
data to copy?

+1 Sounds reasonable to me. It's better to give an explicit error;
otherwise, we would remove data that the user clearly wants to migrate
to the new cluster. And deleting data just because the user forgot to
specify one parameter in a new cluster looks like a bad joke to me.   
 
--
Best regards,
Maxim Orlov.

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Remove custom redundant full page write description from GIN
Next
From: Tomas Vondra
Date:
Subject: Re: Should we update the random_page_cost default value?