Re: [pgAdmin4][patch]: Fix for RM 1320 - Mailing list pgadmin-hackers

From Neel Patel
Subject Re: [pgAdmin4][patch]: Fix for RM 1320
Date
Msg-id CACCA4P3dHgkPte+NYf3yMCXGm=zHo5aEaK5CaSe2n1Hmz2Zg2w@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][patch]: Fix for RM 1320  (Neel Patel <neel.patel@enterprisedb.com>)
Responses Re: [pgAdmin4][patch]: Fix for RM 1320
List pgadmin-hackers
Adding more details.

Root cause:-

When user change schema of already created fdw extension then while creating the new fdw we should append the <schema_name>.<fdw_handler_name>.
Previously we added only <fdw_handler_name> so while executing the query it will not be able to find fdw handler name without schema name.

e.g. If user changed the fdw handler 'postgres_fdw_handler' under schema 'test' then we should display the handler  name under fdw as "test. postgres_fdw_handler".

Solution:-

With this patch, we have added <schema_name>.<fdw_handler_name> so while creating or updating the fdw, proper sql will be generated.

Thanks,
Neel Patel


On Mon, Jul 25, 2016 at 11:02 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

Please find attached patch file for the fix of RM- 1320.

RM-1320 - Unable to create foreign data wrapper when user change the schema of extension 'postgres_fdw_handler'.

Thanks,
Neel Patel

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: [pgAdmin4][patch]: Fix for RM 1320
Next
From: Harshal Dhumal
Date:
Subject: Re: patch for RM1460 [pgAdmin4]