Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4] [Patch]: Resource Group Module - Mailing list pgadmin-hackers

From Neel Patel
Subject Re: [pgAdmin4] [Patch]: Resource Group Module
Date
Msg-id CACCA4P3Cj-CkO2KSQL06eGViLMfujBMY66+=8VbmcXpqWr5WXg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4] [Patch]: Resource Group Module  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin4] [Patch]: Resource Group Module
List pgadmin-hackers
Tree view
Hi Akshay,

Please find below review comments.

 - As per the pgAdmin3, we should allow to enter the floating point value in "CPU Rate Limit" and "Dirty Rate Limit".
 - While creating resource group, we are getting error saying "generate_browser_node() missing 1 required positional argument: 'label'".   
 - Valid range for CPU Rate Limit and Dirty Rate Limit is from 0 to 1.67772e+07. We are not able to enter the maximum limit value while creating the 
   resource group.

Thanks,
Neel Patel

On Fri, Feb 5, 2016 at 6:15 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All 

I have added logic to show sql in the "SQL" tab on dashboard and also fixed some warnings. Please refer and review this patch.

On Thu, Feb 4, 2016 at 5:50 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All

Attached is the patch for the Resource Group Module. Please review it and if it looks good then please commit it. 

--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin III: Muliple SQL tabs
Next
From: Murtuza Zabuawala
Date:
Subject: PATCH: Added macro for default privileges [pgAdmin4]