Postgres Pro
Downloads
Home   >   mailing lists

Re: Unable to update Domain properly - Mailing list pgadmin-hackers

From Neel Patel
Subject Re: Unable to update Domain properly
Date
Msg-id CACCA4P095=s7tBwPTkgoHuhKndqMQxUfCX6bstiO01nym5JhPQ@mail.gmail.com
Whole thread Raw
In response to Unable to update Domain properly  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: Unable to update Domain properly  (Neel Patel <neel.patel@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi,

Please find the attached patch file for fix of above issue.

Issue:- 
Below generated SQL was wrong.

ALTER DOMAIN pem."TestDomain"
  RENAME TO "TestDomain1";
ALTER DOMAIN pem."TestDomain"
  DROP NOT NULL;

In second query, domain name is wrong as domain name was updated by the first query.

Resolution:-

Now when any properties got changed along with domain name then correct SQL will be generated.
Correct query should be as below.

ALTER DOMAIN pem."TestDomain"
  RENAME TO "TestDomain1";
ALTER DOMAIN pem."TestDomain1"
  DROP NOT NULL;

Please review it and do let us know for any comment.

Thanks,
Neel Patel

On Wed, Jan 13, 2016 at 6:43 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

While updating Domain from pgAdmin-III  , I observed an error.

When I update only Domain name it is working properly, but when I try to update multiple fields, I get an error.

For example,  if I try to rename Domain TestDomain to TestDomain1 and also modifies one or more fields (except comment). I get below error.


ERROR:  type "pem.TestDomain" does not exist

Generated SQL:

ALTER DOMAIN pem."TestDomain"
  RENAME TO "TestDomain1";
ALTER DOMAIN pem."TestDomain"
  DROP NOT NULL;


Thanks,
Khushboo

Attachment

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Unable to update Domain properly
Next
From: Andreas 'ads' Scherbaum
Date:
Subject: Re: Updated Greenplum documentation