Re: Build versionless .so for Android - Mailing list pgsql-hackers

From Matthias Kuhn
Subject Re: Build versionless .so for Android
Date
Msg-id CAC7zN97nsF-4oKXYk3ge_4Jsgpyau9Gcjdwr=oHbVHsT9a6nuw@mail.gmail.com
Whole thread Raw
In response to Re: Build versionless .so for Android  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Build versionless .so for Android
List pgsql-hackers
Thanks,

This patch brought it further and indeed, the resulting libpq.so file is unversioned when built for Android while it's versioned when built for linux.

Matthias

On Fri, Jan 19, 2024 at 3:00 PM Peter Eisentraut <peter@eisentraut.org> wrote:
On 19.01.24 11:08, Matthias Kuhn wrote:
> When trying to build with meson, including the patch which was provided
> by Andres Freud (thanks),
> I am currently stuck with the following error:
>
> Configuring pg_config_ext.h using configuration
>
> ../src/tgresql-16-685bc9fc97.clean/src/include/meson.build:12:0: ERROR:
> File port/android.h does not exist.

I think there is actually small bug in the meson setup.

In the top-level meson.build, line 166 has

     portname = host_system

but then later around line 190, host_system is changed for some cases
(including the android case that was added in the proposed patch).  So
that won't work, and probably also won't work for the existing cases
there.  The portname assignment needs to be moved later in the file.
Maybe you can try that on your own.

pgsql-hackers by date:

Previous
From: Amul Sul
Date:
Subject: Re: Add system identifier to backup manifest
Next
From: Amul Sul
Date:
Subject: Re: Add system identifier to backup manifest