Re: Remove support for Visual Studio 2013 - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: Remove support for Visual Studio 2013
Date
Msg-id CAC+AXB2PyaXUWM1DwvizJVD2eryJ2_yeSm66XkfLv4bT5qBjkA@mail.gmail.com
Whole thread Raw
In response to Remove support for Visual Studio 2013  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Remove support for Visual Studio 2013
List pgsql-hackers

On Mon, May 16, 2022 at 8:58 AM Michael Paquier <michael@paquier.xyz> wrote:

The patch attached cleans up the following things proper to VS 2013:
- Locale handling.
- MIN_WINNT assignment.
- Some strtof() business, as of win32_port.h.
- Removal of _set_FMA3_enable() in main.c related to floating-point
operations.
- MSVC scripts, but that's less interesting considering the work done
with meson.

When building on MinGW with NLS enabled I get some errors:

c:/cirrus/src/backend/utils/adt/pg_locale.c: In function 'search_locale_enum':
c:/cirrus/src/backend/utils/adt/pg_locale.c:989:13: warning: implicit declaration of function 'GetLocaleInfoEx'; did you mean 'GetLocaleInfoA'? [-Wimplicit-function-declaration]
  989 |         if (GetLocaleInfoEx(pStr, LOCALE_SENGLISHLANGUAGENAME,
      |             ^~~~~~~~~~~~~~~
      |             GetLocaleInfoA

This is because current MinGW defaults to Windows 2003 [1], maybe we should fix Windows' minimal version to Vista (0x0600) unconditionally also. I have seen a couple of compilation warnings while testing that setting on MinGW, please find attached a patch for so.


Regards,

Juan José Santamaría Flecha
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Add WAL recovery messages with log_wal_traffic GUC (was: add recovery, backup, archive, streaming etc. activity messages to server logs along with ps display)
Next
From: Tom Lane
Date:
Subject: Re: Tracking notnull attributes inside Var