Re: stat() on Windows might cause error if target file is larger than 4GB - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: stat() on Windows might cause error if target file is larger than 4GB
Date
Msg-id CAC+AXB06Q=cYevL1m8goMEtDBSC-_-wHG92vTVDmAHR2bxXqWQ@mail.gmail.com
Whole thread Raw
In response to Re: stat() on Windows might cause error if target file is largerthan 4GB  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers

On Sat, May 9, 2020 at 2:49 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
On 2018-Sep-13, Tom Lane wrote:

> What I was vaguely imagining is that win32_port.h could #include
> whichever Windows header defines these functions and structs, and
> then do
>
> #define stat __stat64
>
> static inline ... __stat64(...) { return _stat64(...); }
>
> What would need testing is whether the #define has nasty side-effects
> even if we've already included the system header.  I don't think it'd
> hurt, eg, local variables named "stat"; though people might be surprised
> when examining things in a debugger.

Did anybody test this idea?  It seems we let this problem slip unfixed,
which means Windows users cannot use pg_dump -Fd (incl. parallel dump)
when output files are large.

This issue gets reported from time to time as bug, it also affects COPY. There is an open item for so:


Regards,

Juan José Santamaría Flecha

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Strange decreasing value of pg_last_wal_receive_lsn()
Next
From: Ranier Vilela
Date:
Subject: Re: [PATCH] Fix division by zero (explain.c)