Re: pg_stat_statements: calls under-estimation propagation - Mailing list pgsql-hackers

From Sameer Thakur
Subject Re: pg_stat_statements: calls under-estimation propagation
Date
Msg-id CABzZFEsvnuYhWGWxTadunsSQod4JvpvSeX4Bj_U153qz9Ai0jw@mail.gmail.com
Whole thread Raw
In response to Re: pg_stat_statements: calls under-estimation propagation  (Sameer Thakur <samthakur74@gmail.com>)
Responses Re: pg_stat_statements: calls under-estimation propagation  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
Hello,
Please find v10 of patch attached. This patch addresses following
review comments
1. Removed errcode and used elogs for error "pg_stat_statements schema
is not supported by its binary"
2. Removed comments and other code formatting not directly relevant to
patch functionality
3. changed position of query_id in view to userid,dbid,query_id..
4 cleaned the patch some more to avoid unnecessary  whitespaces, newlines.

I assume the usage of PGSS_TUP_LATEST after explanation given.
Also the mixing of PG_VERSION_NUM with query_id is ok after after
explanation given.

regards
Sameer

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Sequence Access Method WIP
Next
From: Heikki Linnakangas
Date:
Subject: Re: Sequence Access Method WIP