Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally. - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.
Date
Msg-id CABwTF4Wyp3ym+Nj-+vAnj4Go5jdoepX=P09BpgJdLMd+2g8tbw@mail.gmail.com
Whole thread Raw
In response to Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.  (Kevin Grittner <kgrittn@ymail.com>)
Responses Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.  (Kevin Grittner <kgrittn@ymail.com>)
List pgsql-hackers
On Sun, Jun 29, 2014 at 11:58 AM, Kevin Grittner <kgrittn@ymail.com> wrote:
> I have reviewed this patch, and think we should do what the patch
> is trying to do, but I don't think the submitted patch would
> actually work.

Just curious, why do you think it won't work. Although the discussion
is a bit old, but I'm sure I would've tested the patch before
submitting.

> I have attached a suggested patch which I think
> would work.  Gurjeet, could you take a look at it?

The patch, when considered together with Tom's suggestion upthread,
looks good to me.

Best regards,
-- 
Gurjeet Singh http://gurjeet.singh.im/

EDB : www.EnterpriseDB.com : The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Spinlocks and compiler/memory barriers
Next
From: Mark Kirkwood
Date:
Subject: Re: Wait free LW_SHARED acquisition