Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion? - Mailing list pgsql-hackers

On Fri, Mar 27, 2026 at 3:19 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Mar 27, 2026 at 1:19 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > After this change, why do we need to invoke
> > ProcessSlotSyncInterrupts() twice in SyncReplicationSlots?
> >

Fixed.

>
> Also, not sure if it is a good idea to name current function as
> ProcessSlotSyncInterrupts() because we remove most of its interrupt
> handling. Shall we copy paste its code at two places as we do similar
> handling at other places as well.
>

Done.

> Another comment:
> *
> +
> + if (SlotSyncShutdown)
> + HandleSlotSyncShutdown();
> ...
> ...
> + if (CheckProcSignal(PROCSIG_SLOTSYNC_MESSAGE))
> + HandleSlotSyncShutdownInterrupt();
>
> Would it better if we name these functions as HandleSlotSyncMessage()
> and HandleSlotSyncMessageInterrupt() because for API, these simply
> lead to an ERROR and that would match with the ProcSignalReason name
> PROCSIG_SLOTSYNC_MESSAGE?
>
Done.

Attached the updated patch.

--
Thanks,
Nisha