On Tue, Jun 3, 2025 at 5:11 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, May 29, 2025 at 8:09 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > These comments are handled in the attached v2025029 version patch.
> >
>
> 1. The current syntax to publish sequences is:
> CREATE PUBLICATION pub1 FOR ALL TABLES, ALL SEQUENCES;
>
> The other alternative could be:
> CREATE PUBLICATION pub1 FOR ALL TABLES, SEQUENCES;
>
> I think the syntax proposed by the patch is better because of the
> following reasons: (a) The use of ALL before both objects makes the
> intent explicit and symmetrical. (b) As we are planning to support FOR
> TABLE t1, SEQUENCE s1, so ALL SEQUENCES fit naturally as a counterpart
> to ALL TABLES.
>
> Please let me know if anyone thinks otherwise.
+1
>
> 6. ALTER SUBSCRIPTION ... REFRESH PUBLICATION SEQUENCES
>
> Can we move the implementation of the above command to a separate
> patch? This is to make 0004 shorter and easier to review.
>
Splitted patch-0004 as follows:
- patch-0004: Implements the new REFRESH PUBLICATION SEQUENCES command.
- patch-0005: Implementation of the sequencesync worker.
Attached patches address feedback from Amit [1] and Shveta [2].
[1] https://www.postgresql.org/message-id/CAJpy0uD00JCsgDxL3YjdPQFSnV4mv4D9XPZV_9%3DaMNDLao7SQQ%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAA4eK1%2B6L%2BAoGS3LHdnYnCE%3DnRHergSQyhyO7Y%3D-sOp7isGVMw%40mail.gmail.com
--
Thanks,
Nisha
