Re: Proposal: Conflict log history table for Logical Replication - Mailing list pgsql-hackers

On Wed, Jun 24, 2026 at 7:26 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> Please find the updated patch set attached.

Hi Dilip,

I ran a code coverage report on v56-0001 and v56-0002 and found a few
cases not covered by existing tests. I added tests for the following:

1) check_publication_add_relation() – verify that adding a conflict
table to a publication errors out
2) execMain.c: CheckValidRowMarkRel() – verify row locking on CLT is
rejected for commands like SELECT ... FOR UPDATE
3) The test scenario shared by Shveta at [1]

Please consider the patch if you are okay with it. The patch applies
cleanly on top of latest v58-0002 patch,

[1] https://www.postgresql.org/message-id/CAJpy0uC5x%2BZ%3Dfvurvz%3DK8EYQSCQ1SCouR2LqiHS27Hp_Tzi6qw%40mail.gmail.com

--
Thanks,
Nisha