Re: Implement missing join selectivity estimation for range types - Mailing list pgsql-hackers

Hi Haibo,

Thanks for the continued feedback. Attached is v8 addressing your nits

on patch 2:

- Reworded the commit message to say "the same outer-bounds-based

  estimator can be reused" instead of implying the code is just

  duplicated.

- Made comments in multirangejoinsel type-neutral where they

  unnecessarily said "range" (e.g. "bound histograms" instead of

  "range histograms", "empty values" instead of "empty ranges").

- Added the reverse mixed-direction tests (multirange x range).

Regards,

Maxime

Hi Maxime,

Thanks for addressing those points — this looks good to me now.

If you don’t mind, I’ve created a CommitFest entry for this:
https://commitfest.postgresql.org/patch/6668/

I’ve listed both of us as authors.

I’m not a committer yet, so we’ll need someone else to review and (hopefully) pick this up for commit.

Thanks again for the work on this.

Best regards,
Haibo