Re: pgsql: make dist uses git archive - Mailing list pgsql-committers

From Magnus Hagander
Subject Re: pgsql: make dist uses git archive
Date
Msg-id CABUevEzqaUiXriT_7W+v0rU99XDpCLY-OPn8ZGxzHyRfDz83FA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: make dist uses git archive  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: make dist uses git archive
List pgsql-committers


On Tue, Mar 26, 2024 at 9:13 AM Andrew Dunstan <andrew@dunslane.net> wrote:


On Tue, Mar 26, 2024 at 3:20 AM Peter Eisentraut <peter@eisentraut.org> wrote:
On 25.03.24 23:20, Andrew Dunstan wrote:
> The problem occurs because except in vpath mode the buildfarm operates
> on a copy of the code, and for efficiency reasons we don't copy the ,git
> directory.
>
> The simplest fix is probably to change the machine's config to use a
> vpath build.
>
> In the config file change the undef here to a 1:
>
> 'use_vpath' => undef,
>
> That worked for me in a quick test.

Note that "make dist" doesn't work with vpath in backbranches. :-/


Ugh.

OK, plan B :

In the Module's setup code, right after the "die", put

symlink("$buildroot/$branch/pgsql/.git","$pgsql/.git");


If I understand you right, you meant:

        die "can't run this module with vpath builds"
          if $conf->{vpath};
+       symlink("$buildroot/$branch/pgsql/.git","$pgsql/.git");

        my $self  = {buildroot => $buildroot, pgbranch=> $branch, bfconf => $conf, pgsql => $pgsql};
        bless ($self, $class);


//Magnus

pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: make dist uses git archive
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Remove ObjectClass type