Re: pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns
Date
Msg-id CABUevEzam_r+r+vab8QbWxWou0W7GAa_WUAFSpwH9DdRpaJJmw@mail.gmail.com
Whole thread Raw
In response to pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns  (Jaime Casanova <jaime@2ndquadrant.com>)
Responses Re: pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns  (Jaime Casanova <jaime@2ndquadrant.com>)
List pgsql-hackers
On Wed, Jan 11, 2012 at 22:31, Jaime Casanova <jaime@2ndquadrant.com> wrote:
> Hi,
>
> I just notice $SUBJECT and this could lead us to a segmentation fault
> if by accident we point to a system with a different number of columns
> in IDENTIFY_SYSTEM, at least i point pg_receivexlog from current head
> to a 9.0 instalation and got that.
>
> Any reason for not checking number of columns?

Hmm. I could've bet it did that. I must've taken that code out at some
point during refactoring.

No, no reason. Adding such a check would be a good idea.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: PL/Python result metadata
Next
From: Simon Riggs
Date:
Subject: Re: 16-bit page checksums for 9.2